Fix lints

[yberreby]

In 0c223c6, you added new #![deny(..)] lints, without changing the code accordingly. As a result, doapi-rs fails to build because of missing copy and debug implementations, missing docs and "unnecessary qualifications" that are actually useful — that is, the code fails to compile without them.

This PR removes the three problematic lints, fixes a warning (the append feature is now stable) and runs rustfmt (I couldn't easily do it in a separate commit as I have rust.vim configured to run it automatically on save).

[kbknapp]

👍 Thanks!
@homu r+

[kbknapp]

Ah guess I'm not using @homu on this repo...sad face

Merged.

[yberreby]

Would you mind pushing a new version to crates.io? It looks like to forgot to do it last time you updated the dependencies. As a result, docli-rs too fails to build on nightly because its doapi-rs crates.io dependency uses serde_macros 0.5.3 instead of 0.6.x as specified in the .toml.

❯ cargo build
 Downloading libc v0.2.5
   Compiling libc v0.2.5
   Compiling serde_macros v0.5.3
/Users/yberreby/.multirust/toolchains/nightly/cargo/registry/src/github.com-88ac128001ac3a9a/serde_macros-0.5.3/src/lib.rs:8:35: 8:58 error: failed to resolve. Could not find `plugin` in `rustc` [E0433]
/Users/yberreby/.multirust/toolchains/nightly/cargo/registry/src/github.com-88ac128001ac3a9a/serde_macros-0.5.3/src/lib.rs:8 pub fn plugin_registrar(reg: &mut rustc::plugin::Registry) {
                                                                                                                                                               ^~~~~~~~~~~~~~~~~~~~~~~
/Users/yberreby/.multirust/toolchains/nightly/cargo/registry/src/github.com-88ac128001ac3a9a/serde_macros-0.5.3/src/lib.rs:8:35: 8:58 help: run `rustc --explain E0433` to see a detailed explanation
/Users/yberreby/.multirust/toolchains/nightly/cargo/registry/src/github.com-88ac128001ac3a9a/serde_macros-0.5.3/src/lib.rs:8:35: 8:58 error: use of undeclared type name `rustc::plugin::Registry` [E0412]
/Users/yberreby/.multirust/toolchains/nightly/cargo/registry/src/github.com-88ac128001ac3a9a/serde_macros-0.5.3/src/lib.rs:8 pub fn plugin_registrar(reg: &mut rustc::plugin::Registry) {
                                                                                                                                                               ^~~~~~~~~~~~~~~~~~~~~~~
/Users/yberreby/.multirust/toolchains/nightly/cargo/registry/src/github.com-88ac128001ac3a9a/serde_macros-0.5.3/src/lib.rs:8:35: 8:58 help: run `rustc --explain E0412` to see a detailed explanation
error: aborting due to 2 previous errors
Build failed, waiting for other jobs to finish...
Could not compile `serde_macros`.

$ rustc --version
rustc 1.7.0-nightly (7dce32e65 2016-01-20)

[kbknapp]

Done :) v0.1.2 is out on crates.io

Bare in mind though, I haven't messed with this crate or docli in quite some time - and they were built when I was still very new to Rust so there may be some horrendous architecture in there 😜 One of these days I'd love to go through and clean up some of this!

[yberreby]

Don't worry, I noticed it wasn't touched in a while, but I'm thankful you took the time to write it. I'm considering using these two crates for a project of mine.

By the way, I've just made a PR to docli: kbknapp/docli-rs#16

May as well fix both of them, eh? :)