os_security_group_rule proper module exit (ansible#50076)

When the security group the rule belongs to does not exist and the state is absent, the module is not properly exited, leading to a playbook execution failure. Fixes issue ansible#50057
kbreit · Jan 11, 2019 · dd324db · dd324db
1 parent e5ebe13
commit dd324db
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/changelogs/fragments/50076-os-sec-group-rule-proper-module-exit.yaml b/changelogs/fragments/50076-os-sec-group-rule-proper-module-exit.yaml
@@ -0,0 +1,4 @@
+bugfixes:
+  - os_security_group_rule - os_security_group_rule doesn't exit properly when
+    secgroup doesn't exist and state=absent
+    (https://github.com/ansible/ansible/issues/50057)
diff --git a/lib/ansible/modules/cloud/openstack/os_security_group_rule.py b/lib/ansible/modules/cloud/openstack/os_security_group_rule.py
@@ -359,7 +359,7 @@ def main():
                 cloud.delete_security_group_rule(rule['id'])
                 changed = True
 
-            module.exit_json(changed=changed)
+        module.exit_json(changed=changed)
 
     except sdk.exceptions.OpenStackCloudException as e:
         module.fail_json(msg=str(e))