perf: optimize hydration to use less loops

kbrsh · Jul 20, 2017 · 5c66f8c · 5c66f8c
1 parent e0690f4
commit 5c66f8c
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 35 deletions.
diff --git a/dist/moon.js b/dist/moon.js
@@ -788,28 +788,24 @@
           var i = 0;
           var currentChildNode = node.firstChild;
           var vchild = length !== 0 ? children[0] : null;
+          var nextSibling = null;
 
           while(vchild !== null || currentChildNode !== null) {
-            if(vchild === null) {
-              var nextSibling = null;
-              do {
-                nextSibling = currentChildNode.nextSibling;
+            nextSibling = null;
+
+            if(currentChildNode === null) {
+              appendChild(createNodeFromVNode(vchild), vchild, node);
+            } else {
+              nextSibling = currentChildNode.nextSibling;
+              if(vchild === null) {
                 removeChild(currentChildNode, node);
-                currentChildNode = nextSibling;
-              } while(currentChildNode !== null);
-              currentChildNode = null;
-            } else if(currentChildNode === null) {
-              for(; i < children.length; i++) {
-                vchild = children[i];
-                appendChild(createNodeFromVNode(vchild), vchild, node);
+              } else {
+                hydrate(currentChildNode, vchild, node);
               }
-              vchild = null;
-            } else {
-              var next = currentChildNode.nextSibling;
-              hydrate(currentChildNode, vchild, node);
-              vchild = ++i < length ? children[i] : null;
-              currentChildNode = next;
             }
+
+            vchild = ++i < length ? children[i] : null;
+            currentChildNode = nextSibling;
           }
         }
         return node;