use base for custom setters and add default setter as noop in favor o…

…f custom one
kbrsh · Apr 15, 2017 · 669a3bb · 669a3bb
1 parent 4343cf7
commit 669a3bb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/dist/moon.js b/dist/moon.js
@@ -80,7 +80,8 @@
             }
 
             return cache;
-          }
+          },
+          set: noop
         });
 
         // Add Setters
@@ -1708,7 +1709,7 @@
 
       // Invoke custom setter
       var setter = null;
-      if ((setter = observer.setters[key]) !== undefined) {
+      if ((setter = observer.setters[base]) !== undefined) {
         setter.call(this, val);
       }
 

diff --git a/dist/moon.min.js b/dist/moon.min.js
diff --git a/src/instance/methods.js b/src/instance/methods.js
@@ -32,7 +32,7 @@ Moon.prototype.set = function(key, val) {
 
   // Invoke custom setter
   let setter = null;
-  if((setter = observer.setters[key]) !== undefined) {
+  if((setter = observer.setters[base]) !== undefined) {
     setter.call(this, val);
   }
 

diff --git a/src/observer/computed.js b/src/observer/computed.js
@@ -35,7 +35,8 @@ const initComputed = function(instance, computed) {
         }
 
         return cache;
-      }
+      },
+      set: noop
     });
 
     // Add Setters