Deprecate lastCallFailed. #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icedream
force-pushed
the
deprecate-lastcallfailed
branch
from
fccaa6f
to
3b91de8
Compare
Art4
requested changes
Sep 24, 2021
icedream
force-pushed
the
deprecate-lastcallfailed
branch
from
3b91de8
to
a16bc40
Compare
Art4
requested changes
Sep 25, 2021
icedream
force-pushed
the
deprecate-lastcallfailed
branch
from
a16bc40
to
f3973ab
Compare
|
👍 thanks a lot @icedream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of discussion in #293.
Redmine\Api\AbstractApi::lastCallFailedfails to acknowledge 2xx codes that are not 200 or 201 as success, however changing that method may break old code relying on this behavior.Redmine introduced a change to successful responses in 4.1.0 that leads to API calls such as issue updates leading to a yet undocumented 204 response, more details on that in the other issue.
We already have an alternative way to check for success, and that is to simply check the status code directly by calling
Redmine\Client\Client::getLastResponseStatusCode. This PR will point users towards that method instead.I am going to check whether this can be clarified in the documentation as well somehow before I mark this as ready to review.