[fix] 'route/:id' refresh issue by removing explicit 'base' from vite…

[shellyear]

@blcham solving #125

It works with dev and build. But not in the dockerization, working on it

[blcham]

Seems like you are not returning config.js but index.html (i.e. config.js is search in different path)

[shellyear]

Seems like you are not returning config.js but index.html (i.e. config.js is search in different path)

Yes, the build(production) and dev need the "base" property in vite.config.js to be default "/", but the build for the dockerization should have "base" property as "/record-manager/", because of how it's set in docker-compose.

[shellyear]

@blcham Vite serves the app from the root path (/) by default for the dev and production (base: '/' in vite.config.js) . When build for production, Vite generates the assets with paths relative to the specified base.
The docker-compose.yml > record-manager > environment has a BASENAME custom environment variable which will be then used in config.js.template in .docker folder and written to config.js and then the BASENAME variable will be used in the source code for the react-router as it's property in App.js.
The base in vite.config.js and in the BASENAME should match https://v5.reactrouter.com/web/api/BrowserRouter/basename-string

Current state: works on dev, prod and dockerization

[blcham]

What is motivation to change this?

[shellyear]

@blcham Because I thought of every environment (dev, production) having it's own base in vite.config.js which will use the value of the RECORD_MANAGER_BASENAME based on mode. So the dev environment will have a "/" base, and the production will have a "/record-manager" base . Since the build for production image is then used in dockerization, it means that the base of the build (in vite.config.js) should match with the BASENAME passed via docker (which will be /record-manager, since RECORD_MANAGER_ROOT_PATH in deploy > internal-auth > .env is commented out). https://reactrouter.com/en/main/router-components/router

[blcham]

So what if i decide to have RECORD_MANAGER_ROOT_PATH=/my-record-manager ?

[shellyear]

@blcham It doesn't work after I changed it, I feel stuck now

[blcham]

I might not understand how it works, but

this seems to me strange to use. I thought we had environments set up in

record-manager-ui/config/index.js

Line 33 in 9f44702

export const BASENAME = getEnv("BASENAME", "");

So I am not sure how this setting is useful for us. I thought we would set Router basename instead.

[blcham]

I assume (but did not check) vite.config.js base attribute is set during build time and thus is useless for us for dockerization.

[blcham]

Current state: works on dev, prod and dockerization

I did not test the dockerization, but I have doubts about the solution. I have questions:

1. do setting BASENAME really work in runtime? I.e. i should be possible to do only the following steps:
   • 1.1) after docker-compose up it should work on http://localhost:1235/record-manager
   • 1.2) change .env variable RECORD_MANAGER_ROOT_PATH=/record-manager-super-demo
   • 1.3) after docker-compose up it should work on http://localhost:1235/record-manager-super-demo
   • 1.4) then you can try also RECORD_MANAGER_ROOT_PATH=/testing-complex-path/record-manager-demo :)