Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all images in media content #149

Open
LaChope opened this issue May 5, 2022 · 5 comments
Open

Add support for all images in media content #149

LaChope opened this issue May 5, 2022 · 5 comments

Comments

@LaChope
Copy link
Collaborator

LaChope commented May 5, 2022

@blcham
SForms only support google drive "preview" links for images in media content. Support should be extended to all images, even outside google drive, with possibility to click on image to open the source in another tab.

We have 4 different options:

  1. real image (we support it but do not keep the ratio)
  2. real video (we don't support it)
  3. frame (we support it and proportions of image are kept)
  4. custom URL (e.g. https://drive.google.com/file/d/1ItZqsUm82nKW4ZqvKaiGUn202NEF79FC/view?usp=sharing)
@LaChope LaChope added this to To do in SForms Board via automation May 5, 2022
@LaChope LaChope moved this from To do to In progress in SForms Board May 5, 2022
@LaChope
Copy link
Collaborator Author

LaChope commented May 5, 2022

@blcham
Right now the different medias are displayed vertically, wouldn't be better to display them horizontally?

image

image

@blcham
Copy link
Collaborator

blcham commented May 6, 2022

No because, we want to support mobile interface.

@blcham
Copy link
Collaborator

blcham commented May 6, 2022

@LaChope LaChope moved this from In progress to Review in progress in SForms Board Jun 10, 2022
@LaChope
Copy link
Collaborator Author

LaChope commented Nov 24, 2022

Google drive videos don't work in anonymous tab

@blcham
Copy link
Collaborator

blcham commented Nov 24, 2022

This is the issue:
https://support.google.com/drive/thread/61698038/bug-opening-video-on-google-chrome-incognito-mode-videos-are-not-working?hl=en

The issue is that in incognito mode third-party cookies are not enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
SForms Board
Pending Review
Development

No branches or pull requests

2 participants