Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all images in media content #151

Closed
wants to merge 7 commits into from
Closed

Conversation

LaChope
Copy link
Collaborator

@LaChope LaChope commented May 6, 2022

Added support for all images #149

@LaChope LaChope requested a review from blcham May 6, 2022 09:45
@netlify
Copy link

netlify bot commented May 6, 2022

Deploy Preview for s-forms-kbss ready!

Name Link
🔨 Latest commit e0aa03d
🔍 Latest deploy log https://app.netlify.com/sites/s-forms-kbss/deploys/628f4e4e269cb40008091ac3
😎 Deploy Preview https://deploy-preview-151--s-forms-kbss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@blcham
Copy link
Collaborator

blcham commented May 10, 2022

  • put in parsed url also regular image

Copy link
Collaborator

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • put in parsed url also regular image
  • keep proportions in case 3)
  • we should be able to turn off specific processing of URLs (e.g. google drive preview --> real image)
    option.unifyMediaContent=true (this should be default)

@LaChope LaChope requested a review from blcham May 26, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants