Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle basic validation #153

Closed
2 of 3 tasks
blcham opened this issue May 16, 2022 · 1 comment · Fixed by #207
Closed
2 of 3 tasks

Handle basic validation #153

blcham opened this issue May 16, 2022 · 1 comment · Fixed by #207
Assignees

Comments

@blcham
Copy link
Collaborator

blcham commented May 16, 2022

Requirements:

  • Question can have 3 validation types:

    1. has-required-answer -> Emphasize if answer has no value and focus is lost = missing
    2. pattern (or similar e.g. has-required-pattern... ) -> Emphasize if answer value does not match specified pattern = invalid
    3. form:has-answer-contributing-to-completeness = not complete
  • One question should support all validation types at the same time (e.g. i. and ii.)

  • Should navigate to invalid/missing

Implementation

  • AVA:

    • invalid -> Can't save
    • missing -> User must confirm after pop-up (e.g. 'some fields are missing, do you want to continue'...) => Save as Draft (i.e. Open)
    • missing "required/mandatory" => TO DISCUSS how to differentiate with "normal" missing
    • After record is saved with missing required answers -> Should navigate to first missing/invalid + all missing answers should be emphasized + have a button to navigate to next one (+ counter in the button?)
  • VFN: TO DISCUSS

VojtechLunak added a commit that referenced this issue Apr 12, 2023
…n matching and corresponding validation message; Added new story with manually added JSON-LD attributes to coordinates and address text;
VojtechLunak added a commit that referenced this issue Jun 21, 2023
…m InputAnswer. PatternValidator introduced.
blcham pushed a commit that referenced this issue Jul 12, 2023
…n matching and corresponding validation message; Added new story with manually added JSON-LD attributes to coordinates and address text;
blcham pushed a commit that referenced this issue Jul 12, 2023
blcham pushed a commit that referenced this issue Jul 12, 2023
…n matching and corresponding validation message; Added new story with manually added JSON-LD attributes to coordinates and address text;
blcham pushed a commit that referenced this issue Jul 12, 2023
@LaChope LaChope self-assigned this Feb 8, 2024
@LaChope LaChope linked a pull request Feb 8, 2024 that will close this issue
@blcham blcham mentioned this issue Feb 8, 2024
LaChope added a commit that referenced this issue Feb 14, 2024
@LaChope
Copy link
Collaborator

LaChope commented Feb 14, 2024

@blcham 2 first requirements are now working, I leave the last one "Should navigate to invalid/missing" pending as it needs more discussion

LaChope added a commit that referenced this issue Feb 16, 2024
LaChope added a commit that referenced this issue Feb 16, 2024
LaChope added a commit that referenced this issue Feb 27, 2024
…uestion also has only for completeness validation
LaChope added a commit that referenced this issue Feb 27, 2024
LaChope added a commit that referenced this issue Feb 27, 2024
LaChope added a commit that referenced this issue Mar 1, 2024
…uestion also has only for completeness validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants