Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie chart error if x-axis label not set #1

Open
henrypijames opened this issue Jun 15, 2012 · 0 comments
Open

Pie chart error if x-axis label not set #1

henrypijames opened this issue Jun 15, 2012 · 0 comments

Comments

@henrypijames
Copy link

jquery.svggraph.js line 1461:

graph.xAxis._labels[i])

whereas lines 997, 1087, 1189, 1300:

(axis._labels ? axis._labels[i] : '' + i));

The difference between line 1461 and the other lines means the pie chart is the only one raising an exception when not explicitly initialized with x-axis labels. That can't be right.

But looking at line 1459:

if (graph.xAxis) {

Is there any way for xAxis to be null? Or is line 1461 correct as it is, but line 1459 is supposed to be:

if (graph.xAxis._labels) {
twitwi pushed a commit to twitwi/svg that referenced this issue Nov 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant