Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue 20 #23

Merged
merged 7 commits into from
Dec 31, 2020
Merged

fix: Issue 20 #23

merged 7 commits into from
Dec 31, 2020

Conversation

duffenterprises
Copy link
Contributor

@kchristensen I've added the documentation to support gcloud, and modifications to the shell script.

During my testing last week, I observered that the shell script did not support wildcard DNS entries. Let's Encrypt creates *.whatever.anotherhostname.com as _.whatever.anotherhostname.com.cert (etc) which is why I introduced the regex

LEGO_CERT_NAME=${CERT_NAME/\*/_}

I also observed that Let's Encrypt errored with domains like your original example:

CERT_HOSTS='whatever.hostname.com,*.whatever.hostname.com'

because whatever.hostname.com is encompased within *.whatever.hostname.com, thus the example update to *.whatever.anotherhostname.com.

Hopefully this PR is useful to the UDM community.

@kchristensen
Copy link
Owner

This looks great. Good catch on the wildcard stuff, that was something another contributor added that I don't actually use at home so it wasn't well vetted. Going to merge this now and if I don't hear anyone grumble I'll cut a release announcing google support in a couple of days. Thanks!

@kchristensen kchristensen merged commit 84218db into kchristensen:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants