Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kchristensen I've added the documentation to support gcloud, and modifications to the shell script.
During my testing last week, I observered that the shell script did not support wildcard DNS entries. Let's Encrypt creates
*.whatever.anotherhostname.com
as_.whatever.anotherhostname.com.cert
(etc) which is why I introduced the regexI also observed that Let's Encrypt errored with domains like your original example:
because whatever.hostname.com is encompased within
*.whatever.hostname.com
, thus the example update to*.whatever.anotherhostname.com
.Hopefully this PR is useful to the UDM community.