Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication implementation #40

Merged
merged 16 commits into from
Apr 9, 2022
Merged

Authentication implementation #40

merged 16 commits into from
Apr 9, 2022

Conversation

DangMin
Copy link
Collaborator

@DangMin DangMin commented Apr 5, 2022

No description provided.

@vercel
Copy link

vercel bot commented Apr 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kcjpop/vd/9JGfdbaJfhbHTpFJSG6LmLu3G3Sq
✅ Preview: https://vd-git-feature-authentication-kcjpop.vercel.app

Copy link
Owner

@kcjpop kcjpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seemed to work. We just need to remove api/src/domain-logic/* before merging.

web/package.json Outdated
@@ -16,6 +16,9 @@
"@floating-ui/react-dom-interactions": "0.0.15",
"@logtail/browser": "0.1.10",
"@radix-ui/react-dropdown-menu": "0.1.6",
"@radix-ui/react-toast": "0.1.1",
"@supabase/supabase-js": "1.33.3",
"better-sqlite3": "7.5.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed better-sqlite3 in the FE.

router.push('/')
}

console.log({ user })
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm

DangMin and others added 7 commits April 9, 2022 11:49
- Remove Account, Auth component, supabase.css (from supabase example)
- Add functions and useUser hook
- Add common components: Button, Input
- Add translations for login page
- Remove session props from _app.jsx
- Add Login component.
- Add more views to Register component.
- Fix error on input of Login component.
- Add more translations.
- Add Confirm page: display message and redirect after certain time (10s)
- Add more translations
- Add getProtocol function (can be removed if not needed)
- Fix layout for Login/Register
- Introduce Toast from @radix-ui/react-toast
- Add translations
- Add styling for Toast, additional keyframes for animation.
kcjpop and others added 8 commits April 9, 2022 11:50
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
- Re-adding lib/component/auth/Auth.jsx (lost when migrate to separate api server)
- Add translation
- Remove atom.css. Add additional keyframes (for dropdown).
Minor fixes:
- Wrong usage of useRouter
- Login page styles (too small for mid screen
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop kcjpop merged commit 636a0ad into main Apr 9, 2022
@kcjpop kcjpop deleted the feature/authentication branch April 9, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth: Allow users to register and login
2 participants