Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Feature/pnpm #85

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

PoC: Feature/pnpm #85

wants to merge 6 commits into from

Conversation

kcjpop
Copy link
Owner

@kcjpop kcjpop commented May 1, 2022

What

Try to use pnpm instead of yarn.

Pros 👍

  • It works locally and use less disk space: We can go to web/ api and pnpm install. All packages are stored in <root project dir>/node_modules

Cons 👎

  • Need to change build command on Vercel. So far I haven't succeeded yet, and build time increased from ≈35s to ≈1min. Seems like Vercel can recognize pnpm even inside a sub-directory, so no need to change build command except specifying which directory the Next project is (in our case, web/). Still building time is ~1min 😕 Also got warnings about unsupported node 16 and old pnpm version (Vercel uses node 14 and pnpm 6).
  • Still haven't found a way to build Docker image and deploy to Fly.io. Prolly there is but I'm bored to research 😢 Check https://pnpm.io/cli/fetch

@vercel
Copy link

vercel bot commented May 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vd ✅ Ready (Inspect) Visit Preview May 3, 2022 at 6:48AM (UTC)

kcjpop added 6 commits May 3, 2022 09:47
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
Signed-off-by: An Cao <kcj.pop.com@gmail.com>
@kcjpop kcjpop changed the title WIP: Feature/pnpm PoC: Feature/pnpm May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant