Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Read-write cache optimization for code generation process. #213

Closed
Peefy opened this issue Sep 20, 2022 · 0 comments
Closed

[Enhancement] Read-write cache optimization for code generation process. #213

Peefy opened this issue Sep 20, 2022 · 0 comments
Assignees
@zong-zhe
Labels
codegen
Milestone
v0.4.4 Release

Comments

@Peefy
Copy link
Contributor

Peefy commented Sep 20, 2022

Enhancement

The locks for the assembler at kclvm/runner crate. should be applied to the entire read cache, assembly and write cache processes, not just the assembly process.

Related code: https://github.com/KusionStack/KCLVM/blob/main/kclvm/runner/src/assembler.rs#L422
@Peefy Peefy added the codegen label Sep 20, 2022
@Peefy Peefy added this to the v0.4.4 Release milestone Sep 20, 2022
@zong-zhe zong-zhe mentioned this issue Sep 23, 2022
Merged
16 tasks
Peefy pushed a commit that referenced this issue Sep 23, 2022
@zong-zhe
Fix(kclvm-runner): Fixed file locks in kclvm-runner. (#215)
0fcc2b7 
* Replace relative paths with absolute paths in test cases.

* Fix(kclvm-runner): Fixed file locks in kclvm-runner.

The operations of the read and write cache are also wrapped in the file lock.

fix issue #213.

* remove useless println!

* modified method `clean_path` from pub to pub(crate)
@Peefy Peefy closed this as completed Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zong-zhe zong-zhe

Labels
codegen
Projects
None yet
Milestone
v0.4.4 Release
Development

No branches or pull requests
2 participants
@Peefy @zong-zhe