Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(kclvm-runner): Fixed file locks in kclvm-runner. #215

Merged
merged 4 commits into from Sep 23, 2022
Merged

Fix(kclvm-runner): Fixed file locks in kclvm-runner. #215

merged 4 commits into from Sep 23, 2022

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix issue #213.

2. What is the scope of this PR (e.g. component or file name):

kclvm-runner

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

The operations of the read and write cache are also wrapped in the file lock.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

The operations of the read and write cache are also wrapped in the file lock.

fix issue #213.
@zong-zhe zong-zhe added bug Something isn't working enhancement New feature or request labels Sep 23, 2022
@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Sep 23, 2022
@zong-zhe zong-zhe self-assigned this Sep 23, 2022
kclvm/runner/src/tests.rs Outdated Show resolved Hide resolved
kclvm/runner/src/assembler.rs Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Sep 23, 2022

Pull Request Test Coverage Report for Build 3110114136

  • 122 of 122 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 59.577%

Totals Coverage Status
Change from base Build 3087071675: -0.9%
Covered Lines: 20429
Relevant Lines: 34290

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peefy Peefy merged commit 0fcc2b7 into kcl-lang:main Sep 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants