Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long string quote in the AST printer tool #294

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 14, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: #293

2. What is the scope of this PR (e.g. component or file name):

  • internal/kclvm_py/tools/printer/printer.py
  • kclvm/ast_pretty/src/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/ast_pretty/src/tests.rs
  • test/test_units/test_kclvm/test_tools/test_printer/test_printer.py

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added bug Something isn't working tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. labels Nov 14, 2022
@Peefy Peefy added this to the v0.4.4 Release milestone Nov 14, 2022
@Peefy Peefy self-assigned this Nov 14, 2022
@coveralls
Copy link
Collaborator

coveralls commented Nov 14, 2022

Pull Request Test Coverage Report for Build 3462231228

  • 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-30.2%) to 59.474%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/ast_pretty/src/node.rs 5 8 62.5%
Totals Coverage Status
Change from base Build 3458953081: -30.2%
Covered Lines: 19262
Relevant Lines: 32387

💛 - Coveralls

Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy changed the title fix: long string quote AST pinter fix: long string quote AST printer Nov 15, 2022
@Peefy Peefy changed the title fix: long string quote AST printer fix: long string quote in the AST printer tool Nov 15, 2022
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 0fff266 into kcl-lang:main Nov 15, 2022
@Peefy Peefy deleted the fix-longstr-ast-print branch November 15, 2022 10:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] KCL AST printer does not support long string with string interpolation print.
4 participants