Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify the linker code #1016

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 30, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • refactor: simplify the linker code

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runner/src/linker.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy added this to the v0.8.0 Release milestone Jan 30, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2024

Pull Request Test Coverage Report for Build 7712126228

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 241 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.5%) to 72.322%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/diagnostic_message.rs 3 0.0%
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 11 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
Totals Coverage Status
Change from base Build 7695512104: -15.5%
Covered Lines: 43755
Relevant Lines: 60500

💛 - Coveralls

Signed-off-by: peefy <xpf6677@163.com>
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit fea8406 into kcl-lang:main Jan 31, 2024
11 checks passed
@Peefy Peefy deleted the refactor-linker-code branch January 31, 2024 02:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants