Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix config if expr pos #1027

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix: fix config if expr pos #1027

merged 1 commit into from
Feb 4, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Feb 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/parser/src/parser/expr.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added parser Issues or PRs related to kcl parser lsp labels Feb 4, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7773758623

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.787%

Totals Coverage Status
Change from base Build 7772591237: 0.0%
Covered Lines: 2293
Relevant Lines: 2612

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 13bea0b into kcl-lang:main Feb 4, 2024
12 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lsp parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants