Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build-in method 'file.read' to load file #1034

Merged
merged 4 commits into from
Feb 18, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Feb 8, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #995

2. What is the scope of this PR (e.g. component or file name):

add a built-in function to load file

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the enhancement New feature or request label Feb 8, 2024
@zong-zhe zong-zhe added this to the v0.8.0 Release milestone Feb 8, 2024
@zong-zhe zong-zhe requested review from i-zhen and Peefy February 8, 2024 03:02
@zong-zhe zong-zhe self-assigned this Feb 8, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 8, 2024

Pull Request Test Coverage Report for Build 7945756833

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -34 of 35 (2.86%) changed or added relevant lines in 3 files are covered.
  • 241 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.5%) to 72.298%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/_kclvm_addr.rs 0 1 0.0%
kclvm/sema/src/builtin/system_module.rs 1 17 5.88%
kclvm/runtime/src/file/mod.rs 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/diagnostic_message.rs 3 0.0%
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 11 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
Totals Coverage Status
Change from base Build 7798962109: -15.5%
Covered Lines: 43880
Relevant Lines: 60693

💛 - Coveralls

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kclvm/sema/src/builtin/system_module.rs Outdated Show resolved Hide resolved
kclvm/sema/src/builtin/system_module.rs Outdated Show resolved Hide resolved
kclvm/runtime/src/file/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: zongz <zongzhe1024@163.com>
@Peefy Peefy merged commit 9829e26 into kcl-lang:main Feb 18, 2024
10 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants