Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raw identifier in the schema string attribute #1045

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 18, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: raw identifier in the schema string attribute

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/pre_process/identifier.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/sema/src/pre_process/test_data/raw_identifier.k
  • kclvm/sema/src/pre_process/tests.rs

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added bug Something isn't working pass labels Feb 18, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Feb 18, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7946181476

Details

  • -3 of 15 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 72.3%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/pre_process/tests.rs 5 8 62.5%
Totals Coverage Status
Change from base Build 7946135307: 0.002%
Covered Lines: 43891
Relevant Lines: 60707

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 35cfe95 into kcl-lang:main Feb 18, 2024
5 of 8 checks passed
@Peefy Peefy deleted the fix-schema-str-attr-fix branch February 18, 2024 03:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants