Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add builtin io function glob() #1051

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Feb 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #1049

2. What is the scope of this PR (e.g. component or file name):

add built-in function glob()

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zong-zhe <zongzhe1024@163.com>
@zong-zhe zong-zhe added the enhancement New feature or request label Feb 19, 2024
@zong-zhe zong-zhe added this to the v0.8.0 Release milestone Feb 19, 2024
@zong-zhe zong-zhe self-assigned this Feb 19, 2024
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
@Peefy
Copy link
Contributor

Peefy commented Feb 19, 2024

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7954406993

Details

  • -34 of 34 (0.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 72.255%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/_kclvm_addr.rs 0 1 0.0%
kclvm/sema/src/builtin/system_module.rs 0 14 0.0%
kclvm/runtime/src/file/mod.rs 0 19 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/builtin/system_module.rs 1 97.77%
Totals Coverage Status
Change from base Build 7954296266: -0.04%
Covered Lines: 43899
Relevant Lines: 60756

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 0a174f9 into kcl-lang:main Feb 19, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants