Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add builtin io function workdir() #1054

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Feb 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #1049

2. What is the scope of this PR (e.g. component or file name):

add built-in function workdir().

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Feb 19, 2024
@zong-zhe zong-zhe added this to the v0.8.0 Release milestone Feb 19, 2024
@zong-zhe zong-zhe requested a review from Peefy February 19, 2024 11:44
@zong-zhe zong-zhe self-assigned this Feb 19, 2024
main.k Outdated Show resolved Hide resolved
@zong-zhe zong-zhe force-pushed the add-builtin-workdir branch 2 times, most recently from cb9e551 to 58f760f Compare February 21, 2024 02:34
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zong-zhe <zongzhe1024@163.com>
Signed-off-by: zong-zhe <zongzhe1024@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 7984591037

Details

  • 43 of 66 (65.15%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 71.808%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/_kclvm_addr.rs 0 2 0.0%
kclvm/runtime/src/context/mod.rs 0 3 0.0%
kclvm/runtime/src/context/api.rs 0 9 0.0%
kclvm/runtime/src/file/mod.rs 0 9 0.0%
Totals Coverage Status
Change from base Build 7983193669: -0.01%
Covered Lines: 44245
Relevant Lines: 61616

💛 - Coveralls

Signed-off-by: zong-zhe <zongzhe1024@163.com>
@Peefy Peefy merged commit cc38aee into kcl-lang:main Feb 21, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
@zong-zhe zong-zhe deleted the add-builtin-workdir branch June 12, 2024 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants