Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add load_builtin option for the loader API and add more unit test cases #1055

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #989

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/loader/src/lib.rs
  • kclvm/sema/src/core/symbol.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/loader/src/tests.rs

…st cases

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added the api Issues or PRs related to kcl rust native APIs and multi-lang APIs label Feb 19, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Feb 19, 2024
@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label Feb 19, 2024
@Peefy Peefy requested a review from zong-zhe February 19, 2024 12:51
@Peefy Peefy self-assigned this Feb 19, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7959808088

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -25 of 51 (50.98%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 72.551%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/core/symbol.rs 0 3 0.0%
kclvm/loader/src/lib.rs 3 25 12.0%
Totals Coverage Status
Change from base Build 7957502370: 0.2%
Covered Lines: 44137
Relevant Lines: 60836

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 80168d7 into kcl-lang:main Feb 20, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
@Peefy Peefy deleted the feat-load-package-builtin-symbol-api branch February 20, 2024 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants