Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove all schema internal settings attribute and use the potential schema type #1062

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 21, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #1060

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/value/val_plan.rs
  • kclvm/runtime/src/value/val_schema.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/**

@Peefy Peefy added bug Something isn't working runtime Issues or PRs related to kcl runtime including value and value opertions labels Feb 21, 2024
@Peefy Peefy force-pushed the remove-all-schema-settings branch 2 times, most recently from 3f9c922 to 6e03f08 Compare February 21, 2024 10:17
…c to the runtime

Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7988197848

Details

  • -140 of 341 (58.94%) changed or added relevant lines in 19 files are covered.
  • 55 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.005%) to 71.824%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runner/src/lib.rs 1 2 50.0%
kclvm/runner/src/runner.rs 54 55 98.18%
kclvm/runner/src/tests.rs 3 4 75.0%
kclvm/runtime/src/context/api.rs 0 1 0.0%
kclvm/runtime/src/value/val_type.rs 0 2 0.0%
kclvm/runtime/src/value/val_clone.rs 1 4 25.0%
kclvm/runtime/src/value/val_json.rs 1 4 25.0%
kclvm/runtime/src/yaml/mod.rs 0 3 0.0%
kclvm/runtime/src/json/mod.rs 0 5 0.0%
kclvm/runtime/src/value/val_schema.rs 17 22 77.27%
Files with Coverage Reduction New Missed Lines %
kclvm/runner/src/runner.rs 1 94.95%
kclvm/runtime/src/_kcl_run.rs 1 0.0%
kclvm/runtime/src/value/val_get_set.rs 1 96.67%
kclvm/runtime/src/value/api.rs 2 0.0%
kclvm/runtime/src/value/val_json.rs 2 79.56%
kclvm/runtime/src/value/val_str.rs 4 2.15%
kclvm/runtime/src/value/val_is_in.rs 5 76.64%
kclvm/runtime/src/value/val_dict.rs 6 52.57%
kclvm/tools/src/LSP/src/request.rs 14 66.44%
kclvm/runtime/src/value/val_plan.rs 19 74.76%
Totals Coverage Status
Change from base Build 7987930085: 0.005%
Covered Lines: 44290
Relevant Lines: 61665

💛 - Coveralls

@Peefy Peefy merged commit d84bb41 into kcl-lang:main Feb 21, 2024
8 checks passed
@Peefy Peefy deleted the remove-all-schema-settings branch February 21, 2024 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__settings__ key in output when iterating over object of schema type
2 participants