Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the show_hidden flag #1070

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 21, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #536

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/api/src/service/into.rs
  • kclvm/cmd/src/lib.rs
  • kclvm/cmd/src/settings.rs
  • kclvm/runner/src/runner.rs
  • kclvm/spec/gpyrpc/gpyrpc.proto

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Unit test

  • kclvm/runner/src/test_datas/exec_prog_args/default.json
  • kclvm/runner/src/test_datas/settings_file/settings.json
  • kclvm/config/src/settings.rs

e2e test

  • test/grammar/show_hidden/**

@Peefy Peefy added this to the v0.8.0 Release milestone Feb 21, 2024
@Peefy Peefy added the feat label Feb 21, 2024
Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 7989219958

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 5 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 71.827%

Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 14 66.44%
Totals Coverage Status
Change from base Build 7988522327: -0.02%
Covered Lines: 44298
Relevant Lines: 61673

💛 - Coveralls

@Peefy Peefy merged commit 1a5d199 into kcl-lang:main Feb 21, 2024
8 checks passed
@Peefy Peefy deleted the feat-show-hidden-flag branch February 21, 2024 13:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add -H/--show-hidden flag to show hidden attributes e.g. _hidden_attr
2 participants