Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stack overflow issues caused by deep copy of circular references within schema and schema lambda #1079

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 24, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: stack overflow issues caused by deep copy of circular references within schema and schema lambda

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/value/val_clone.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/lambda/in_schema_5/main.k

@Peefy Peefy added bug Something isn't working runtime Issues or PRs related to kcl runtime including value and value opertions labels Feb 24, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Feb 24, 2024
@Peefy Peefy self-assigned this Feb 24, 2024
… within schema and schema lambda

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy merged commit e97ead5 into kcl-lang:main Feb 24, 2024
6 of 8 checks passed
@Peefy Peefy deleted the fix-issue-1078 branch February 24, 2024 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant