Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: empty result plan to dict #1080

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 24, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • refactor: empty result plan to dict

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/context.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added the codegen label Feb 24, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Feb 24, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 24, 2024

Pull Request Test Coverage Report for Build 8028965868

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 71.927%

Totals Coverage Status
Change from base Build 8017960617: 0.003%
Covered Lines: 44248
Relevant Lines: 61518

💛 - Coveralls

@Peefy Peefy merged commit c40e499 into kcl-lang:main Feb 24, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2024
@Peefy Peefy deleted the refactor-empty-plan-result-to-dict branch February 24, 2024 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants