Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support arguments and keyword arguments union for the schema value #1086

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 26, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #1084

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/node.rs
  • kclvm/runner/src/runner.rs
  • kclvm/runtime/src/api/kclvm.rs
  • kclvm/runtime/src/value/val_union.rs
  • kclvm/runtime/src/value/val_type.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/union/arguments/**

@Peefy Peefy added runtime Issues or PRs related to kcl runtime including value and value opertions feat labels Feb 26, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Feb 26, 2024
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Feb 26, 2024

Pull Request Test Coverage Report for Build 8048904166

Details

  • 23 of 70 (32.86%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 71.867%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/value/val_type.rs 0 3 0.0%
kclvm/runtime/src/value/val_clone.rs 0 4 0.0%
kclvm/runtime/src/value/val_schema.rs 14 22 63.64%
kclvm/runtime/src/value/val_union.rs 2 14 14.29%
kclvm/runtime/src/value/api.rs 0 20 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/runtime/src/value/api.rs 1 0.0%
Totals Coverage Status
Change from base Build 8046921574: -0.04%
Covered Lines: 44290
Relevant Lines: 61628

💛 - Coveralls

@Peefy Peefy merged commit 565acbb into kcl-lang:main Feb 26, 2024
8 checks passed
@Peefy Peefy deleted the feat-schema-args-union branch February 26, 2024 13:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Union operator incompatible with instances of a schema that have schema arguments
3 participants