Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add better error message and quick fix for the list schema member #1089

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #1087

feat: add better error message and quick fix for the list schema member

image

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/config.rs
  • kclvm/tools/src/LSP/src/quick_fix.rs
  • kclvm/sema/src/resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/sema/src/resolver/tests.rs

@Peefy Peefy added refactor feat error-handling Issues or PRs related to kcl error handling resolver and removed refactor labels Feb 27, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Feb 27, 2024
@Peefy Peefy force-pushed the enhance-config-attr-check-err-msg branch from 0b5eaf1 to 59c9a86 Compare February 27, 2024 01:57
@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8058477239

Details

  • 36 of 42 (85.71%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.893%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/quick_fix.rs 0 1 0.0%
kclvm/sema/src/resolver/config.rs 31 36 86.11%
Totals Coverage Status
Change from base Build 8049667463: 0.03%
Covered Lines: 44328
Relevant Lines: 61658

💛 - Coveralls

@Peefy Peefy merged commit 4586e81 into kcl-lang:main Feb 27, 2024
8 checks passed
@Peefy Peefy deleted the enhance-config-attr-check-err-msg branch February 27, 2024 02:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-handling Issues or PRs related to kcl error handling feat resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need better error message for typo in lists
2 participants