Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add builtin function 'crypto.uuid()' and 'crypto.filehash()' #1090

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Feb 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #313

2. What is the scope of this PR (e.g. component or file name):

feat: add builtin function 'crypto.uuid()' and 'crypto.filehash()'

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zong-zhe <zongzhe1024@163.com>
@zong-zhe zong-zhe added enhancement New feature or request api Issues or PRs related to kcl rust native APIs and multi-lang APIs labels Feb 27, 2024
@zong-zhe zong-zhe added this to the v0.8.0 Release milestone Feb 27, 2024
@zong-zhe zong-zhe requested a review from Peefy February 27, 2024 01:45
@zong-zhe zong-zhe self-assigned this Feb 27, 2024
@zong-zhe zong-zhe changed the title fix: add builtin function 'crypto.uuid()' feat: add builtin function 'crypto.uuid()' Feb 27, 2024
@Peefy Peefy changed the title feat: add builtin function 'crypto.uuid()' feat: add builtin function 'crypto.uuid()' and 'crypto.filehash()' Feb 27, 2024
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy added the module label Feb 27, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8060920412

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -42 of 84 (50.0%) changed or added relevant lines in 4 files are covered.
  • 107 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.07%) to 71.936%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runner/src/tests.rs 20 21 95.24%
kclvm/runtime/src/_kclvm_addr.rs 0 2 0.0%
kclvm/runtime/src/crypto/mod.rs 0 39 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/ast/src/ast.rs 1 83.49%
kclvm/sema/src/resolver/tests.rs 1 98.75%
kclvm/sema/src/resolver/node.rs 35 80.58%
kclvm/sema/src/resolver/config.rs 70 79.95%
Totals Coverage Status
Change from base Build 8049667463: 0.07%
Covered Lines: 44415
Relevant Lines: 61742

💛 - Coveralls

@Peefy Peefy merged commit a88f639 into kcl-lang:main Feb 27, 2024
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
@zong-zhe zong-zhe deleted the add-crypto-uuid branch June 12, 2024 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs enhancement New feature or request module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants