Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: literal str and join str inner completion #1092

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Feb 27, 2024

Remove the special judgment for literal strings during completion, and change the search for the nearest symbol during completion to the symbol one or two characters before the trigger.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1083

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa self-assigned this Feb 27, 2024
@He1pa He1pa added the lsp label Feb 27, 2024
@Peefy Peefy added the bug Something isn't working label Feb 27, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Feb 27, 2024
@Peefy Peefy changed the title feat: fix literal str and join str inner completion fix: literal str and join str inner completion Feb 27, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8077694267

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 71.939%

Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/util.rs 3 71.11%
Totals Coverage Status
Change from base Build 8065148886: 0.003%
Covered Lines: 44401
Relevant Lines: 61720

💛 - Coveralls

@He1pa He1pa force-pushed the fix_join_str_complete branch 2 times, most recently from 36a7afd to bc0a0ca Compare February 28, 2024 08:54
…on, and change the search for the nearest symbol during completion to the symbol one or two characters before the trigger.

Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit f620ec5 into kcl-lang:main Feb 28, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working lsp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Wrong dot completion for the internal interpolation content of string
3 participants