Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add decorator symbol #1094

Merged
merged 1 commit into from
Feb 29, 2024
Merged

feat: add decorator symbol #1094

merged 1 commit into from
Feb 29, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Feb 29, 2024

add decorator symbol in advanced resolver, add sema highlight nd hover for decorator symbol

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #1068

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver
kclvm/tools/src/LSP

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

add decorator symbol in advanced resolver, add sema highlight nd hover for decorator symbol

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…nd hover for decorator symbol

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added semantic Issues or PRs related to kcl semantic and checker lsp labels Feb 29, 2024
@He1pa He1pa self-assigned this Feb 29, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 3ecb1dd into kcl-lang:main Feb 29, 2024
7 of 8 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8094122079

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 86 of 153 (56.21%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 71.905%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/advanced_resolver/node.rs 15 16 93.75%
kclvm/sema/src/core/global_state.rs 17 18 94.44%
kclvm/tools/src/LSP/src/document_symbol.rs 0 1 0.0%
kclvm/tools/src/LSP/src/hover.rs 9 10 90.0%
kclvm/tools/src/LSP/src/semantic_token.rs 0 1 0.0%
kclvm/sema/src/core/symbol.rs 45 107 42.06%
Totals Coverage Status
Change from base Build 8078550644: -0.03%
Covered Lines: 44490
Relevant Lines: 61873

💛 - Coveralls

@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lsp semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: add symbol for the decorator in the semantic model.
3 participants