Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance anoymous schema type checking in the expr context stack #1096

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 29, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: enhance anoymous schema type checking in the expr context stack

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/config.rs
  • kclvm/sema/src/resolver/node.rs
  • kclvm/sema/src/resolver/var.rs
  • kclvm/tools/src/LSP/src/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/sema/src/resolver/test_fail_data/unmatched_nest_schema_attr_0.k
  • kclvm/sema/src/resolver/test_fail_data/unmatched_nest_schema_attr_1.k
  • kclvm/sema/src/resolver/test_fail_data/unmatched_nest_schema_attr_2.k
  • kclvm/sema/src/resolver/test_fail_data/unmatched_nest_schema_attr_3.k
  • kclvm/sema/src/resolver/test_fail_data/unmatched_schema_attr_0.k
  • kclvm/sema/src/resolver/test_fail_data/unmatched_schema_attr_1.k
  • kclvm/sema/src/resolver/test_fail_data/unmatched_schema_attr_2.k
  • kclvm/sema/src/resolver/test_fail_data/unmatched_schema_attr_3.k

@Peefy Peefy added the resolver label Feb 29, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Feb 29, 2024
@Peefy Peefy added the enhancement New feature or request label Mar 1, 2024
@Peefy Peefy requested review from He1pa and zong-zhe March 1, 2024 02:34
@Peefy Peefy force-pushed the enhance-anonymous-schema-type-checking branch from a875099 to f183887 Compare March 1, 2024 02:43
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link
Collaborator

coveralls commented Mar 1, 2024

Pull Request Test Coverage Report for Build 8105783039

Details

  • 52 of 57 (91.23%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 71.914%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/config.rs 31 36 86.11%
Totals Coverage Status
Change from base Build 8099055692: 0.02%
Covered Lines: 44519
Relevant Lines: 61906

💛 - Coveralls

@Peefy Peefy merged commit bacb189 into kcl-lang:main Mar 1, 2024
8 checks passed
@Peefy Peefy deleted the enhance-anonymous-schema-type-checking branch March 1, 2024 03:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request resolver
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants