Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add better error message for else if token parse recovery #1102

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: add better error message for else if token parse recovery

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/parser/src/parser/stmt.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/parser/src/tests/error_recovery.rs
  • test/grammar/syntax/else_if_token/main.k

@Peefy Peefy added parser Issues or PRs related to kcl parser error-handling Issues or PRs related to kcl error handling labels Mar 4, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Mar 4, 2024
@Peefy Peefy requested review from He1pa and zong-zhe March 4, 2024 08:22
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8137513406

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 71.919%

Totals Coverage Status
Change from base Build 8128113426: 0.005%
Covered Lines: 44530
Relevant Lines: 61917

💛 - Coveralls

@Peefy Peefy merged commit d7ac6ac into kcl-lang:main Mar 4, 2024
8 checks passed
@Peefy Peefy deleted the better-error-msg-for-else-if-token branch March 4, 2024 09:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-handling Issues or PRs related to kcl error handling parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants