Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add datafile parameter for the validate_code api #1103

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Mar 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re kcl-lang/cli#49

2. What is the scope of this PR (e.g. component or file name):

add an api validate_file to validate the json and yaml file

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Mar 4, 2024
@zong-zhe zong-zhe added this to the v0.8.0 Release milestone Mar 4, 2024
@zong-zhe zong-zhe requested a review from Peefy March 4, 2024 08:55
@zong-zhe zong-zhe self-assigned this Mar 4, 2024
Signed-off-by: zongz <zongzhe1024@163.com>
@Peefy Peefy added feat api Issues or PRs related to kcl rust native APIs and multi-lang APIs and removed bug Something isn't working labels Mar 4, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy changed the title feat: add api validate_file feat: add datafile parameter for the validate_code api Mar 4, 2024
Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe merged commit 059bf38 into kcl-lang:main Mar 4, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
@zong-zhe zong-zhe deleted the vet-file-api branch June 12, 2024 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs feat
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants