Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance schema attribute not found error message #1105

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #527

feat: enhance schema attribute not found error message

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/var.rs
  • kclvm/sema/src/resolver/scope.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/var_not_define_fail/var_not_define_fail_0/main.k
  • test/grammar/schema/var_not_define_fail/var_not_define_fail_1/main.k

@Peefy Peefy added this to the v0.8.0 Release milestone Mar 4, 2024
@Peefy Peefy added resolver error-handling Issues or PRs related to kcl error handling labels Mar 4, 2024
@Peefy Peefy requested review from He1pa and zong-zhe March 4, 2024 13:02
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the enhance-schema-attribute-error-message branch from 463dea0 to b3f2780 Compare March 4, 2024 13:53
@coveralls
Copy link
Collaborator

coveralls commented Mar 4, 2024

Pull Request Test Coverage Report for Build 8141326871

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 71.927%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/var.rs 15 16 93.75%
Totals Coverage Status
Change from base Build 8139200011: 0.004%
Covered Lines: 44551
Relevant Lines: 61939

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit ee99380 into kcl-lang:main Mar 5, 2024
8 checks passed
@Peefy Peefy deleted the enhance-schema-attribute-error-message branch March 5, 2024 02:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-handling Issues or PRs related to kcl error handling resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Unified content and style of KCL error messages.
4 participants