Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix completion when schema end pos is eof #1109

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Mar 5, 2024

Insert a fake new line character to expand the scope of the schema, used to complete the schema attributes at the end of the file

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1099

2. What is the scope of this PR (e.g. component or file name):

kclvm/parser/src/parser/stmt.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa self-assigned this Mar 5, 2024
@He1pa He1pa added parser Issues or PRs related to kcl parser lsp labels Mar 5, 2024
…e character to expand the scope of the schema.

Signed-off-by: he1pa <18012015693@163.com>
@Peefy Peefy added this to the v0.8.0 Release milestone Mar 5, 2024
@He1pa He1pa force-pushed the fix_schema_eof_completion branch from 0987127 to 5a00706 Compare March 5, 2024 07:49
Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8153053515

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 71.871%

Totals Coverage Status
Change from base Build 8150348322: 0.002%
Covered Lines: 44530
Relevant Lines: 61958

💛 - Coveralls

@Peefy Peefy merged commit 41648c6 into kcl-lang:main Mar 5, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lsp parser Issues or PRs related to kcl parser
Projects
None yet
3 participants