Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: high order lambda closure captures #1116

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 7, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: high order lambda closure captures

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/context.rs
  • kclvm/compiler/src/codegen/llvm/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/lambda/closure_6/main.k
  • test/grammar/lambda/closure_7/main.k
  • test/grammar/lambda/closure_8/main.k
  • test/grammar/lambda/closure_9/main.k
  • test/grammar/lambda/closure_10/main.k

@Peefy Peefy added the codegen label Mar 7, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 7, 2024
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the feat-high-order-lambda-closure branch from f4b230f to 57d2aa4 Compare March 8, 2024 03:28
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8198319360

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 69 of 105 (65.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 71.727%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/compiler/src/codegen/llvm/context.rs 59 95 62.11%
Totals Coverage Status
Change from base Build 8187055617: -0.02%
Covered Lines: 44571
Relevant Lines: 62140

💛 - Coveralls

@Peefy Peefy merged commit 03005f3 into kcl-lang:main Mar 8, 2024
7 of 8 checks passed
@Peefy Peefy deleted the feat-high-order-lambda-closure branch March 8, 2024 05:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants