Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add semantic with cache API #1122

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 11, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • chore: clean udeps for the semantic API
  • feat: add semantic with cache API
  • kclvm/loader/src/lib.rs

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/loader/Cargo.toml
  • kclvm/parser/Cargo.toml

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added the chore label Mar 11, 2024
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy changed the title chore: clean udeps for the semantic API feat: add semantic with cache API Mar 11, 2024
@Peefy Peefy added the feat label Mar 11, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8227530402

Details

  • 15 of 16 (93.75%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 71.933%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/loader/src/lib.rs 15 16 93.75%
Totals Coverage Status
Change from base Build 8226703335: 0.01%
Covered Lines: 44734
Relevant Lines: 62188

💛 - Coveralls

@Peefy Peefy merged commit 1b465c9 into kcl-lang:main Mar 11, 2024
8 checks passed
@Peefy Peefy deleted the chore-clean-udeps-for-sematic-api branch March 11, 2024 04:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants