Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: lsp and resolver code structure and cargo clippy #1123

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 11, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • refactor: lsp and resolver code structure and cargo clippy

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/driver/src/lib.rs
  • kclvm/sema/src/resolver/mod.rs
  • kclvm/sema/src/resolver/scope.rs
  • kclvm/tools/src/LSP/src/**.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • All lsp uni test cases

Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8230748872

Details

  • 710 of 741 (95.82%) changed or added relevant lines in 15 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 71.913%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/driver/src/lib.rs 20 21 95.24%
kclvm/tools/src/LSP/src/document_symbol.rs 7 8 87.5%
kclvm/tools/src/LSP/src/quick_fix.rs 2 3 66.67%
kclvm/tools/src/LSP/src/state.rs 4 6 66.67%
kclvm/tools/src/LSP/src/word_index.rs 520 528 98.48%
kclvm/tools/src/LSP/src/find_refs.rs 17 26 65.38%
kclvm/tools/src/LSP/src/rename.rs 33 42 78.57%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/find_refs.rs 1 90.69%
kclvm/sema/src/resolver/mod.rs 1 98.95%
Totals Coverage Status
Change from base Build 8228014003: -0.02%
Covered Lines: 44688
Relevant Lines: 62142

💛 - Coveralls

@Peefy Peefy merged commit 86df640 into kcl-lang:main Mar 11, 2024
8 checks passed
@Peefy Peefy deleted the refactor-resolver-func-param-names branch March 11, 2024 12:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants