Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove python-like static type tricks #1124

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 11, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #341

Semantic simplification of operators (Python tricks) #

  • Disable the use and operation of bool variables 1+True
  • Prohibit comparison between list and config variables [0]<[1] or {} < {}

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/calculation.rs
  • kclvm/sema/src/ty/constructor.rs
  • kclvm/sema/src/ty/context.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/types/binary_expr/binary_expr_0/main.k
  • test/grammar/types/binary_expr/binary_expr_1/main.k
  • test/grammar/types/binary_expr/binary_expr_2/main.k
  • test/grammar/types/binary_expr/binary_expr_fail_0/main.k
  • test/grammar/types/binary_expr/binary_expr_fail_1/main.k
  • test/grammar/types/binary_expr/binary_expr_fail_2/main.k

@Peefy Peefy added the type-system Issues or PRs related to kcl type system label Mar 11, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 11, 2024
@Peefy Peefy requested review from He1pa and zong-zhe March 11, 2024 12:05
Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8232693727

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 71.905%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/ty/constructor.rs 3 95.31%
Totals Coverage Status
Change from base Build 8232451325: -0.008%
Covered Lines: 44679
Relevant Lines: 62136

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 0d9c398 into kcl-lang:main Mar 12, 2024
8 checks passed
@Peefy Peefy deleted the remove-py-type-trick branch March 12, 2024 02:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type-system Issues or PRs related to kcl type system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants