Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resolve cache err in concurreny error in lsp and enhance log message #1129

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Mar 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/request.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added bug Something isn't working lsp labels Mar 12, 2024
@He1pa He1pa force-pushed the fix_concurrency_cache_err branch from 85ce7c5 to 29866fc Compare March 12, 2024 11:53
@coveralls
Copy link
Collaborator

coveralls commented Mar 12, 2024

Pull Request Test Coverage Report for Build 8248319904

Details

  • 25 of 41 (60.98%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 71.911%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/request.rs 25 41 60.98%
Totals Coverage Status
Change from base Build 8246659516: 0.02%
Covered Lines: 44725
Relevant Lines: 62195

💛 - Coveralls

@Peefy Peefy merged commit 7499323 into kcl-lang:main Mar 12, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working lsp
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants