Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: lambda in for high level closures #1130

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • enhance: lambda in for high level closures

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/node.rs
  • kclvm/compiler/src/codegen/llvm/context.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/lambda/in_for_3/main.k

@Peefy Peefy added this to the v0.9.0 Release milestone Mar 12, 2024
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the enhance-in-for-lambda-closure branch from c7a8e98 to 61590e3 Compare March 12, 2024 13:47
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8249933874

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 71.935%

Files with Coverage Reduction New Missed Lines %
kclvm/compiler/src/codegen/llvm/context.rs 1 75.5%
Totals Coverage Status
Change from base Build 8248934631: 0.02%
Covered Lines: 44741
Relevant Lines: 62196

💛 - Coveralls

@Peefy Peefy merged commit dc0799e into kcl-lang:main Mar 12, 2024
7 of 8 checks passed
@Peefy Peefy deleted the enhance-in-for-lambda-closure branch March 12, 2024 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants