Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: lsp cached scope usage #1136

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 14, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • refactor: lsp cached scope usage

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/tools/src/LSP/src/**

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • All unit test cases

…iple file change processes

Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added the lsp label Mar 14, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 14, 2024
@Peefy Peefy requested review from He1pa and zong-zhe March 14, 2024 13:47
@Peefy Peefy merged commit f095db0 into kcl-lang:main Mar 14, 2024
6 of 8 checks passed
@Peefy Peefy deleted the refactor-lsp-cached-scope-usage branch March 14, 2024 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant