Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list options required param #1138

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 15, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: list options required param

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/loader/src/option.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/api/src/capi_test.rs
  • kclvm/loader/src/snapshots/kclvm_loader__tests__list_options_3.snap
  • kclvm/loader/src/snapshots/kclvm_loader__tests__list_options_2.snap

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added the api Issues or PRs related to kcl rust native APIs and multi-lang APIs label Mar 15, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 15, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 15, 2024

Pull Request Test Coverage Report for Build 8290904640

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 72.226%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/eval/mod.rs 1 18.87%
Totals Coverage Status
Change from base Build 8282621570: 0.09%
Covered Lines: 44950
Relevant Lines: 62235

💛 - Coveralls

@Peefy Peefy merged commit a1132d1 into kcl-lang:main Mar 15, 2024
7 of 8 checks passed
@Peefy Peefy deleted the fix-list-options-required-param branch March 15, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants