Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more node walker for evaluator #1160

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 25, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #291

  • feat: add more node walker for evaluator

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/ast/src/ast.rs
  • kclvm/evaluator/src/calculation.rs
  • kclvm/evaluator/src/context.rs
  • kclvm/evaluator/src/function.rs
  • kclvm/evaluator/src/module.rs
  • kclvm/evaluator/src/node.rs
  • kclvm/evaluator/src/scope.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/evaluator/src/tests.rs

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the add-more-node-walker-for-evaluator branch from 6525a88 to eaea076 Compare March 25, 2024 14:34
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8421840308

Details

  • 580 of 1379 (42.06%) changed or added relevant lines in 12 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 71.493%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/ast/src/ast.rs 0 1 0.0%
kclvm/evaluator/src/function.rs 0 4 0.0%
kclvm/evaluator/src/value.rs 27 50 54.0%
kclvm/evaluator/src/context.rs 62 117 52.99%
kclvm/runtime/src/value/val_func.rs 0 67 0.0%
kclvm/evaluator/src/module.rs 0 73 0.0%
kclvm/evaluator/src/calculation.rs 78 194 40.21%
kclvm/evaluator/src/scope.rs 169 369 45.8%
kclvm/evaluator/src/node.rs 111 371 29.92%
Files with Coverage Reduction New Missed Lines %
kclvm/evaluator/src/node.rs 6 32.68%
Totals Coverage Status
Change from base Build 8418949293: 0.3%
Covered Lines: 46098
Relevant Lines: 64479

💛 - Coveralls

@Peefy Peefy merged commit 121e4c0 into kcl-lang:main Mar 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants