Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lsp request retry. #1163

Merged
merged 2 commits into from
Mar 27, 2024
Merged

feat: lsp request retry. #1163

merged 2 commits into from
Mar 27, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Mar 26, 2024

retry document_symbol and semantic tokens request when in compiling

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…t when in compiling

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added the lsp label Mar 26, 2024
kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/request.rs Show resolved Hide resolved
kclvm/tools/src/LSP/src/dispatcher.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/dispatcher.rs Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Mar 26, 2024

Pull Request Test Coverage Report for Build 8447958252

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 31 of 49 (63.27%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 72.04%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/dispatcher.rs 17 18 94.44%
kclvm/tools/src/LSP/src/error.rs 0 8 0.0%
kclvm/tools/src/LSP/src/request.rs 11 20 55.0%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 1 69.23%
Totals Coverage Status
Change from base Build 8438341163: -0.006%
Covered Lines: 46527
Relevant Lines: 64585

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit f48aa81 into kcl-lang:main Mar 27, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants