Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config merge and unpack in loop for #1175

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 29, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #1172
Close #1171

  • fix: config merge and unpack in loop for

2. What is the scope of this PR (e.g. component or file name):

Codegen & Evaluator

  • kclvm/compiler/src/codegen/llvm/node.rs
  • kclvm/evaluator/src/node.rs

Resolver

  • kclvm/sema/src/resolver/node.rs

Others

  • kclvm/runner/src/runner.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/sema/src/resolver/test_fail_data/comp_clause_error_3.k
  • kclvm/sema/src/resolver/test_fail_data/comp_clause_error_4.k
  • kclvm/sema/src/resolver/tests.rs
  • test/grammar/datatype/dict/merge_in_comprehension_0/main.k
  • test/grammar/datatype/dict/merge_in_comprehension_1/main.k

@Peefy Peefy added bug Something isn't working codegen resolver evaluator labels Mar 29, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 29, 2024
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy merged commit c235886 into kcl-lang:main Mar 29, 2024
8 checks passed
@Peefy Peefy deleted the fix-config-merge-in-loop branch March 29, 2024 04:51
He1pa added a commit to He1pa/KCLVM that referenced this pull request Apr 1, 2024
Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa mentioned this pull request Apr 1, 2024
16 tasks
Peefy pushed a commit that referenced this pull request Apr 1, 2024
fix: advance resolver walk dict comp. ref #1175

Signed-off-by: he1pa <18012015693@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant