Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add all positional and keyword arguments for builtin functions #1181

Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 29, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: add all positional and keyword arguments for builtin functions

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/file/mod.rs
  • kclvm/runtime/src/stdlib/builtin_api.rs
  • kclvm/runtime/src/value/val_args.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • All runtime and grammar tests

@Peefy Peefy added this to the v0.9.0 Release milestone Mar 29, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 29, 2024

Pull Request Test Coverage Report for Build 8482233571

Details

  • 6 of 105 (5.71%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 72.292%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/file/mod.rs 0 4 0.0%
kclvm/runtime/src/value/val_args.rs 3 20 15.0%
kclvm/runtime/src/stdlib/builtin_api.rs 3 81 3.7%
Totals Coverage Status
Change from base Build 8479411648: -0.03%
Covered Lines: 47438
Relevant Lines: 65620

💛 - Coveralls

@Peefy Peefy merged commit 288c2dc into kcl-lang:main Mar 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants