Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl more evaluator features and pass more test cases #1182

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 30, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: impl more evaluator features and pass more test cases

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/evaluator

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 30, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 30, 2024

Pull Request Test Coverage Report for Build 8490453449

Details

  • 224 of 378 (59.26%) changed or added relevant lines in 14 files are covered.
  • 8 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.009%) to 72.301%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/evaluator/src/module.rs 3 4 75.0%
kclvm/runner/src/lib.rs 25 29 86.21%
kclvm/runner/src/runner.rs 0 4 0.0%
kclvm/evaluator/src/context.rs 19 24 79.17%
kclvm/evaluator/src/rule.rs 0 5 0.0%
kclvm/evaluator/src/scope.rs 2 15 13.33%
kclvm/evaluator/src/calculation.rs 27 44 61.36%
kclvm/evaluator/src/schema.rs 45 73 61.64%
kclvm/evaluator/src/proxy.rs 0 34 0.0%
kclvm/evaluator/src/node.rs 73 116 62.93%
Files with Coverage Reduction New Missed Lines %
kclvm/evaluator/src/scope.rs 1 71.24%
kclvm/evaluator/src/context.rs 1 85.23%
kclvm/evaluator/src/schema.rs 1 61.26%
kclvm/evaluator/src/calculation.rs 1 55.7%
kclvm/evaluator/src/node.rs 1 61.44%
kclvm/runtime/src/value/val_schema.rs 3 71.12%
Totals Coverage Status
Change from base Build 8482631818: 0.009%
Covered Lines: 47544
Relevant Lines: 65758

💛 - Coveralls

@Peefy Peefy merged commit c9822a3 into kcl-lang:main Mar 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants